Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cross-compile builds #6609

Merged
merged 2 commits into from Apr 14, 2019

Conversation

@techknowlogick
Copy link
Member

commented Apr 14, 2019

Fix #6600

@sapk

sapk approved these changes Apr 14, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Apr 14, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@3297b8d). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6609   +/-   ##
=========================================
  Coverage          ?   40.47%           
=========================================
  Files             ?      405           
  Lines             ?    54388           
  Branches          ?        0           
=========================================
  Hits              ?    22012           
  Misses            ?    29349           
  Partials          ?     3027

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3297b8d...410a5b0. Read the comment docs.

@@ -332,7 +334,7 @@ release-windows:
fi
xgo -dest $(DIST)/binaries -tags 'netgo $(TAGS)' -ldflags '-linkmode external -extldflags "-static" $(LDFLAGS)' -targets 'windows/*' -out gitea-$(VERSION) .
ifeq ($(CI),drone)
mv /build/* $(DIST)/binaries
cp /build/* $(DIST)/binaries

This comment has been minimized.

Copy link
@lunny

lunny Apr 14, 2019

Member

Should we cp -r?

This comment has been minimized.

Copy link
@lafriks

lafriks Apr 14, 2019

Member

Why recursive?

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Apr 14, 2019

@techknowlogick techknowlogick merged commit 38889f0 into go-gitea:master Apr 14, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details

@techknowlogick techknowlogick deleted the techknowlogick:fix-cross-compile branch Apr 14, 2019

techknowlogick added a commit to techknowlogick/gitea that referenced this pull request Apr 14, 2019

lafriks added a commit that referenced this pull request Apr 14, 2019

Fix cross-compile builds (#6609) (#6615)
* Fix cross-compile builds (#6609)

* Update Makefile

* remove bash requirement

@lunny lunny referenced this pull request Apr 16, 2019

Closed

1.7.6 release unusual contents in .sha256 file #6646

2 of 7 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.