Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Trace Logging on Permission Denied & ColorFormat #6618
This PR adds
It also adds a new additional way for providing colored logs for structs in a semi-standardised way. e.g.
log.Info("Log me a user %-v", user)
Structs that want to implement this need to provide a
@@ Coverage Diff @@ ## master #6618 +/- ## ========================================== - Coverage 40.79% 40.73% -0.07% ========================================== Files 421 421 Lines 57570 57866 +296 ========================================== + Hits 23487 23569 +82 - Misses 30955 31168 +213 - Partials 3128 3129 +1
Ah yes but constructing the trace call is not free - so if we can avoid constructing it at all that may make sense.
A lot of the calls there are less complex than I originally had them because I moved functionality into colorformat, so we could remove a few of the IsTrace calls but not all