Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API OTP Context #6674

Merged
merged 11 commits into from Apr 19, 2019

Conversation

@techknowlogick
Copy link
Member

commented Apr 18, 2019

as title

@techknowlogick techknowlogick added this to the 1.9.0 milestone Apr 18, 2019

@techknowlogick techknowlogick requested review from zeripath and go-gitea/owners Apr 18, 2019

techknowlogick added some commits Apr 18, 2019

@techknowlogick techknowlogick requested a review from go-gitea/maintainers Apr 18, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Apr 18, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@dae94e3). Click here to learn what that means.
The diff coverage is 18.75%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6674   +/-   ##
=========================================
  Coverage          ?   41.39%           
=========================================
  Files             ?      415           
  Lines             ?    56382           
  Branches          ?        0           
=========================================
  Hits              ?    23338           
  Misses            ?    29913           
  Partials          ?     3131
Impacted Files Coverage Δ
modules/context/auth.go 20.22% <0%> (ø)
modules/auth/auth.go 49.6% <0%> (ø)
routers/api/v1/api.go 75.31% <25%> (ø)
modules/context/api.go 48.48% <38.88%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dae94e3...6772540. Read the comment docs.

@jolheiser
Copy link
Member

left a comment

Looks good so far, just needs the discussed changes from Discord. 👍

techknowlogick added some commits Apr 19, 2019

@jolheiser
Copy link
Member

left a comment

One small nit

Show resolved Hide resolved modules/context/auth.go Outdated

techknowlogick added some commits Apr 19, 2019

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Apr 19, 2019

Show resolved Hide resolved routers/api/v1/api.go

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Apr 19, 2019

@lafriks lafriks merged commit 19ec260 into go-gitea:master Apr 19, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details

techknowlogick added a commit to techknowlogick/gitea that referenced this pull request Apr 19, 2019

lunny added a commit that referenced this pull request Apr 19, 2019

@techknowlogick techknowlogick deleted the techknowlogick:api-2fa branch Apr 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.