Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API OTP Context #6674

Merged
merged 11 commits into from Apr 19, 2019
Merged

API OTP Context #6674

merged 11 commits into from Apr 19, 2019

Conversation

techknowlogick
Copy link
Member

as title

@techknowlogick techknowlogick requested a review from a team April 18, 2019 22:40
@codecov-io
Copy link

codecov-io commented Apr 18, 2019

Codecov Report

No coverage uploaded for pull request base (master@dae94e3). Click here to learn what that means.
The diff coverage is 18.75%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6674   +/-   ##
=========================================
  Coverage          ?   41.39%           
=========================================
  Files             ?      415           
  Lines             ?    56382           
  Branches          ?        0           
=========================================
  Hits              ?    23338           
  Misses            ?    29913           
  Partials          ?     3131
Impacted Files Coverage Δ
modules/context/auth.go 20.22% <0%> (ø)
modules/auth/auth.go 49.6% <0%> (ø)
routers/api/v1/api.go 75.31% <25%> (ø)
modules/context/api.go 48.48% <38.88%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dae94e3...6772540. Read the comment docs.

Copy link
Member

@jolheiser jolheiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, just needs the discussed changes from Discord. 👍

Copy link
Member

@jolheiser jolheiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit

modules/context/auth.go Outdated Show resolved Hide resolved
routers/api/v1/api.go Show resolved Hide resolved
@lafriks lafriks merged commit 19ec260 into go-gitea:master Apr 19, 2019
lunny pushed a commit that referenced this pull request Apr 19, 2019
@techknowlogick techknowlogick deleted the api-2fa branch April 21, 2019 03:01
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

None yet

6 participants