Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix team members API #6714

Merged
merged 7 commits into from Apr 24, 2019

Conversation

@lunny
Copy link
Member

commented Apr 23, 2019

will fix #6704

@lunny lunny added the kind/bug label Apr 23, 2019

@lunny lunny added this to the 1.9.0 milestone Apr 23, 2019

@zeripath

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

Integration tests need to be updated

lunny added some commits Apr 23, 2019

@lunny lunny force-pushed the lunny:lunny/fix_teams branch from 82e9285 to da3c1c0 Apr 24, 2019

@lunny lunny added the backport/v1.8 label Apr 24, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Apr 24, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@e0172f0). Click here to learn what that means.
The diff coverage is 30%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6714   +/-   ##
=========================================
  Coverage          ?   40.73%           
=========================================
  Files             ?      421           
  Lines             ?    57902           
  Branches          ?        0           
=========================================
  Hits              ?    23585           
  Misses            ?    31184           
  Partials          ?     3133
Impacted Files Coverage Δ
routers/api/v1/api.go 68.04% <30%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0172f0...eadb22a. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Apr 24, 2019

Show resolved Hide resolved routers/api/v1/api.go Outdated
Update routers/api/v1/api.go
Co-Authored-By: lunny <xiaolunwen@gmail.com>

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Apr 24, 2019

lunny added some commits Apr 24, 2019

@techknowlogick techknowlogick merged commit 59be704 into go-gitea:master Apr 24, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details

@techknowlogick techknowlogick changed the title fix team members API Fix team members API Apr 24, 2019

@techknowlogick

This comment has been minimized.

Copy link
Member

commented Apr 24, 2019

@lunny please backport 😄

@lunny lunny deleted the lunny:lunny/fix_teams branch Apr 24, 2019

lunny added a commit to lunny/gitea that referenced this pull request Apr 24, 2019

@lunny

This comment has been minimized.

Copy link
Member Author

commented Apr 24, 2019

@lunny lunny added the backport/done label Apr 24, 2019

lunny added a commit that referenced this pull request Apr 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.