Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] Load issue attributes when editing an issue #6723

Merged
merged 3 commits into from Apr 23, 2019

Conversation

@jolheiser
Copy link
Member

commented Apr 23, 2019

Fixes #6721

Previously assignees on the issue were nil since they weren't loaded, which messed up any ranging that happened when comparing.

jolheiser added some commits Apr 23, 2019

Load issue attributes when editing.
Signed-off-by: jolheiser <john.olheiser@gmail.com>
Add return
Signed-off-by: jolheiser <john.olheiser@gmail.com>

@techknowlogick techknowlogick added this to the 1.9.0 milestone Apr 23, 2019

@adelowo

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

Nice catch... We really need more tests for the api handlers

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Apr 23, 2019

@techknowlogick

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

@jolheiser thanks for PR :) I'll be merging this once build is complete, could you create a backport PR once I merge this one?

@jolheiser

This comment has been minimized.

Copy link
Member Author

commented Apr 23, 2019

@techknowlogick Sure thing! 😄

@codecov-io

This comment has been minimized.

Copy link

commented Apr 23, 2019

Codecov Report

Merging #6723 into master will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6723      +/-   ##
==========================================
+ Coverage   40.72%   40.73%   +0.01%     
==========================================
  Files         421      421              
  Lines       57867    57872       +5     
==========================================
+ Hits        23567    23575       +8     
+ Misses      31171    31167       -4     
- Partials     3129     3130       +1
Impacted Files Coverage Δ
routers/api/v1/repo/issue.go 23.22% <0%> (-0.25%) ⬇️
routers/repo/view.go 42.6% <0%> (+1%) ⬆️
models/repo_list.go 67.89% <0%> (+1.05%) ⬆️
models/unit.go 51.42% <0%> (+5.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbf8538...c0485d4. Read the comment docs.

@techknowlogick techknowlogick merged commit 45fa5cc into go-gitea:master Apr 23, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
@lafriks

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

Please create backport to 1.8 branch

jolheiser added a commit to jolheiser/gitea that referenced this pull request Apr 23, 2019

@jolheiser jolheiser deleted the jolheiser:6721_delete_assignee_api branch Apr 23, 2019

lafriks added a commit that referenced this pull request Apr 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
You can’t perform that action at this time.