Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop is_bare IDX only when it exists for MySQL and MariaDB #6736

Merged
merged 4 commits into from Apr 24, 2019

Conversation

@adelowo
Copy link
Member

commented Apr 24, 2019

@lafriks lafriks added this to the 1.9.0 milestone Apr 24, 2019

Show resolved Hide resolved models/migrations/v78.go
@codecov-io

This comment has been minimized.

Copy link

commented Apr 24, 2019

Codecov Report

Merging #6736 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6736      +/-   ##
=========================================
- Coverage   40.82%   40.8%   -0.02%     
=========================================
  Files         421     421              
  Lines       57902   57910       +8     
=========================================
- Hits        23640   23633       -7     
- Misses      31123   31139      +16     
+ Partials     3139    3138       -1
Impacted Files Coverage Δ
models/migrations/v78.go 0% <0%> (ø) ⬆️
models/unit.go 45.71% <0%> (-5.72%) ⬇️
modules/log/event.go 64.46% <0%> (-1.53%) ⬇️
routers/repo/view.go 41.6% <0%> (-1.01%) ⬇️
models/repo_list.go 67.89% <0%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d8b521...cca25e3. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Apr 24, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Apr 24, 2019

lafriks added some commits Apr 24, 2019

@lafriks lafriks merged commit 821184c into go-gitea:master Apr 24, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
@lafriks

This comment has been minimized.

Copy link
Member

commented Apr 24, 2019

please backport to release/v1.8

@adelowo adelowo deleted the adelowo:fix_migration_78 branch Apr 24, 2019

adelowo added a commit to adelowo/gitea that referenced this pull request Apr 24, 2019

Drop is_bare IDX only when it exists for MySQL and MariaDB (go-gitea#…
…6736)

* Drop is_bare IDX only when it exists

* show indexes only on mysql or mariadb

adelowo added a commit to adelowo/gitea that referenced this pull request Apr 24, 2019

Drop is_bare IDX only when it exists for MySQL and MariaDB (go-gitea#…
…6736)

* Drop is_bare IDX only when it exists

* show indexes only on mysql or mariadb

zeripath added a commit that referenced this pull request Apr 24, 2019

Drop is_bare IDX only when it exists for MySQL and MariaDB (#6736) (#…
…6744)

* Drop is_bare IDX only when it exists

* show indexes only on mysql or mariadb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.