Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stricter domain name pattern in email regex #6739

Merged
merged 2 commits into from Apr 25, 2019

Conversation

@mrsdizzie
Copy link
Contributor

commented Apr 24, 2019

Fixes #6735

@codecov-io

This comment has been minimized.

Copy link

commented Apr 24, 2019

Codecov Report

Merging #6739 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6739      +/-   ##
==========================================
- Coverage      41%   40.98%   -0.02%     
==========================================
  Files         421      421              
  Lines       57915    57915              
==========================================
- Hits        23746    23735      -11     
- Misses      31010    31021      +11     
  Partials     3159     3159
Impacted Files Coverage Δ
modules/markup/html.go 81% <ø> (ø) ⬆️
models/unit.go 45.71% <0%> (-5.72%) ⬇️
models/repo_indexer.go 66.52% <0%> (-1.28%) ⬇️
models/repo_list.go 66.84% <0%> (-1.06%) ⬇️
routers/repo/view.go 41.6% <0%> (-1.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a58832...62d5b0d. Read the comment docs.

@lafriks lafriks added the kind/bug label Apr 24, 2019

@lafriks lafriks added this to the 1.9.0 milestone Apr 24, 2019

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Apr 24, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Apr 24, 2019

@techknowlogick techknowlogick merged commit 0064535 into go-gitea:master Apr 25, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details

@lunny lunny added the backport/v1.8 label Apr 25, 2019

@lunny

This comment has been minimized.

Copy link
Member

commented Apr 25, 2019

Please send backport to release/v1.8

@mrsdizzie

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2019

This can't be cherry picked because of 6293736 which also changes this line. Want me to create a separate commit on release/v1.8 that just does the same thing?

@techknowlogick

This comment has been minimized.

Copy link
Member

commented Apr 26, 2019

@mrsdizzie yes please

mrsdizzie added a commit to mrsdizzie/gitea that referenced this pull request Apr 26, 2019

lafriks added a commit that referenced this pull request Apr 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
You can’t perform that action at this time.