Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug when sort repos on org home page login with non-admin #6741

Merged
merged 5 commits into from Apr 24, 2019

Conversation

@lunny
Copy link
Member

commented Apr 24, 2019

Will fix #6511 with integration tests

@lunny lunny added the kind/bug label Apr 24, 2019

@lunny lunny added this to the 1.9.0 milestone Apr 24, 2019

@lunny lunny changed the title fix bug when sort repos on org home page login with non-admin Fix bug when sort repos on org home page login with non-admin Apr 24, 2019

@lunny lunny force-pushed the lunny:lunny/fix_org_repo_sort branch from 4bc8c4b to a6daf03 Apr 24, 2019

@lunny lunny added the backport/v1.8 label Apr 24, 2019


var (
users = []string{"user1", "user2"}
kases = map[string][]string{

This comment has been minimized.

Copy link
@mrsdizzie

mrsdizzie Apr 24, 2019

Contributor
Suggested change
kases = map[string][]string{
cases = map[string][]string{
for _, user := range users {
t.Run(user, func(t *testing.T) {
session := loginUser(t, user)
for sortBy, repos := range kases {

This comment has been minimized.

Copy link
@mrsdizzie

mrsdizzie Apr 24, 2019

Contributor
Suggested change
for sortBy, repos := range kases {
for sortBy, repos := range cases {
@lunny

This comment has been minimized.

Copy link
Member Author

commented Apr 24, 2019

@mrsdizzie done.

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Apr 24, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Apr 24, 2019

Codecov Report

Merging #6741 into master will increase coverage by 0.16%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6741      +/-   ##
==========================================
+ Coverage   40.82%   40.98%   +0.16%     
==========================================
  Files         421      421              
  Lines       57910    57915       +5     
==========================================
+ Hits        23640    23738      +98     
+ Misses      31131    31018     -113     
- Partials     3139     3159      +20
Impacted Files Coverage Δ
models/org.go 70.03% <100%> (+0.23%) ⬆️
routers/user/home.go 47.76% <100%> (+9.72%) ⬆️
models/unit.go 45.71% <0%> (-5.72%) ⬇️
routers/repo/view.go 41.6% <0%> (-1.01%) ⬇️
models/user.go 50.78% <0%> (+0.27%) ⬆️
models/repo.go 47.96% <0%> (+0.58%) ⬆️
routers/user/profile.go 38.09% <0%> (+1.73%) ⬆️
modules/context/org.go 32.75% <0%> (+31.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 821184c...fbc02a4. Read the comment docs.

@zeripath zeripath merged commit ff03b2f into go-gitea:master Apr 24, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details

@lunny lunny deleted the lunny:lunny/fix_org_repo_sort branch Apr 25, 2019

lunny added a commit to lunny/gitea that referenced this pull request Apr 25, 2019

techknowlogick added a commit that referenced this pull request Apr 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
You can’t perform that action at this time.