Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth2 token can be used in basic auth #6747

Merged
merged 7 commits into from Apr 25, 2019

Conversation

@techknowlogick
Copy link
Member

commented Apr 25, 2019

This includes API calls and git clones
(username is token and password is either empty or x-oauth-basic)

@jonasfranz If possible could you review as you have most knowledge of OAuth2 implementation.

git clone using oauth2 token
oauth token can be used in basic auth

@techknowlogick techknowlogick added this to the 1.9.0 milestone Apr 25, 2019

@techknowlogick techknowlogick requested a review from jonasfranz Apr 25, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Apr 25, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@199faad). Click here to learn what that means.
The diff coverage is 19.04%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6747   +/-   ##
=========================================
  Coverage          ?   41.02%           
=========================================
  Files             ?      421           
  Lines             ?    57955           
  Branches          ?        0           
=========================================
  Hits              ?    23777           
  Misses            ?    31022           
  Partials          ?     3156
Impacted Files Coverage Δ
routers/repo/http.go 38.07% <11.11%> (ø)
modules/auth/auth.go 49.23% <25%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 199faad...11fc783. Read the comment docs.

@Tchoupinax

This comment has been minimized.

Copy link

commented Apr 25, 2019

Hello :)

This fix solves my problem ! (After migrating Gitea to 1.8 and Drone to 1.1.0). Thank you ! ;)

Show resolved Hide resolved routers/repo/http.go Outdated

techknowlogick added some commits Apr 25, 2019

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Apr 25, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Apr 25, 2019

@techknowlogick techknowlogick merged commit ec2d489 into go-gitea:master Apr 25, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details

@techknowlogick techknowlogick deleted the techknowlogick:git_clone_oauth branch Apr 25, 2019

techknowlogick added a commit that referenced this pull request Apr 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
You can’t perform that action at this time.