Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing return #6751

Merged
merged 2 commits into from Apr 25, 2019

Conversation

@lunny
Copy link
Member

commented Apr 25, 2019

No description provided.

@lunny lunny added this to the 1.9.0 milestone Apr 25, 2019

@lunny lunny requested a review from jonasfranz Apr 25, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Apr 25, 2019

Codecov Report

Merging #6751 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6751      +/-   ##
==========================================
- Coverage   40.99%   40.98%   -0.01%     
==========================================
  Files         421      421              
  Lines       57933    57934       +1     
==========================================
- Hits        23748    23744       -4     
- Misses      31026    31031       +5     
  Partials     3159     3159
Impacted Files Coverage Δ
routers/user/oauth.go 43.86% <0%> (-0.14%) ⬇️
modules/log/file.go 75.52% <0%> (-2.1%) ⬇️
routers/repo/view.go 41.6% <0%> (-1.01%) ⬇️
models/gpg_key.go 54.72% <0%> (+0.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65b3f51...b0dc634. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Apr 25, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Apr 25, 2019

@lunny lunny merged commit e8f4c77 into go-gitea:master Apr 25, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details

@lunny lunny deleted the lunny:lunny/fix_miss_return branch Apr 25, 2019

lunny added a commit to lunny/gitea that referenced this pull request Apr 25, 2019

@lunny lunny referenced this pull request Apr 25, 2019

Merged

fix missing return (#6751) #6756

techknowlogick added a commit that referenced this pull request Apr 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.