Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix org visibility bug when git cloning (#6743) #6762

Merged
merged 1 commit into from Apr 26, 2019

Conversation

@lunny
Copy link
Member

commented Apr 26, 2019

  • fix org visibility bug

  • fix permission check

  • add integration tests

  • fix tests

  • change test user name for easier maintainance and fix test

  • fix test git repo name

Please check the following:

  1. Make sure you are targeting the master branch, pull requests on release branches are only allowed for bug fixes.
  2. Read contributing guidelines: https://github.com/go-gitea/gitea/blob/master/CONTRIBUTING.md
  3. Describe what your pull request does and which issue you're targeting (if any)

You MUST delete the content above including this line before posting, otherwise your pull request will be invalid.

Fix org visibility bug when git cloning (#6743)
* fix org visibility bug

* fix permission check

* add integration tests

* fix tests

* change test user name for easier maintainance and fix test

* fix test git repo name

@lunny lunny added the kind/bug label Apr 26, 2019

@lunny lunny added this to the 1.8.1 milestone Apr 26, 2019

@lunny

This comment has been minimized.

Copy link
Member Author

commented Apr 26, 2019

back port from #6743 and will fix #6491

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Apr 26, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Apr 26, 2019

@lafriks lafriks merged commit 81adf6a into go-gitea:release/v1.8 Apr 26, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details

@lunny lunny deleted the lunny:lunny/fix_perm2 branch Apr 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.