Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Detect and restore encoding and BOM in content (#6727) #6765

Merged

Conversation

@zeripath
Copy link
Contributor

commented Apr 26, 2019

Detect and remove a decoded BOM when showing content.
Restore the previous encoding and BOM when updating content.
On error keep as UTF-8 encoding with no BOM.

Signed-off-by: Andrew Thornton art27@cantab.net

Detect encoding and BOM in content (#6727)
Detect and remove a decoded BOM when showing content.
Restore the previous encoding and BOM when updating content.
On error keep as UTF-8 encoding.

Signed-off-by: Andrew Thornton <art27@cantab.net>

@zeripath zeripath added this to the 1.8.1 milestone Apr 26, 2019

@zeripath zeripath changed the title Detect encoding and BOM in content (#6727) UI: Detect and restore encoding and BOM in content (#6727) Apr 26, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Apr 26, 2019

lafriks and others added some commits Apr 26, 2019

@techknowlogick techknowlogick modified the milestones: 1.8.1, 1.9.0 Apr 27, 2019

@techknowlogick techknowlogick modified the milestones: 1.9.0, 1.8.1 Apr 27, 2019

@techknowlogick

This comment has been minimized.

Copy link
Member

commented Apr 27, 2019

make LG-TM work

@techknowlogick techknowlogick merged commit 21fb791 into go-gitea:release/v1.8 Apr 27, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details

@zeripath zeripath deleted the zeripath:fix-#6716-backport-v1.8 branch May 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.