Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support git.PATH entry in app.ini #6772

Merged
merged 6 commits into from Jul 7, 2019

Conversation

8 participants
@typeless
Copy link
Contributor

commented Apr 27, 2019

A user can specify the location of the git executable rather than relying on the PATH environment.

@lunny

This comment has been minimized.

Copy link
Member

commented Apr 27, 2019

I remember there are some other places use git command directly outside of modules/git. I think they also should be replaced.

@typeless

This comment has been minimized.

Copy link
Contributor Author

commented Apr 27, 2019

@lunny I can identify some of them. But I cannot be sure about the effort and time to get them fixed before I look around what is available.

@codecov-io

This comment has been minimized.

Copy link

commented Apr 27, 2019

Codecov Report

Merging #6772 into master will increase coverage by 0.02%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6772      +/-   ##
==========================================
+ Coverage   41.22%   41.24%   +0.02%     
==========================================
  Files         468      468              
  Lines       63364    63375      +11     
==========================================
+ Hits        26122    26140      +18     
+ Misses      33829    33819      -10     
- Partials     3413     3416       +3
Impacted Files Coverage Δ
modules/setting/git.go 46.15% <0%> (-6.03%) ⬇️
modules/git/git.go 33.73% <33.33%> (-0.94%) ⬇️
modules/git/repo_commit.go 52.49% <0%> (+6.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d9d6aa...a89c50b. Read the comment docs.

@lafriks lafriks added this to the 1.9.0 milestone Apr 27, 2019

@lunny

This comment has been minimized.

Copy link
Member

commented Apr 27, 2019

@typeless that could be another PR. Also all process.Manager().ExecDir should be merged with git.NewCommand. But now, I think you should replace all the git params on process.Manager().ExecDir to git.GitExecutable.

@lunny

This comment has been minimized.

Copy link
Member

commented Jul 7, 2019

conflicted

@typeless typeless force-pushed the typeless:add-git-path-for-ini branch from c678aab to fc591d5 Jul 7, 2019

@typeless

This comment has been minimized.

Copy link
Contributor Author

commented Jul 7, 2019

@lunny Done.

I got the error when building it at my local machine. I think it has nothing to do with this change though.

 ~/src/code.gitea.io/gitea  ⑂ add-git-path-for-ini    make generate build
go: github.com/denisenkom/go-mssqldb@v0.0.0-20180314172330-6a30f4e59a44: reading https://proxy.golang.org/github.com/denisenkom/go-mssqldb/@v/v0.0.0-20180314172330-6a30f4e59a44.mod: 400 Bad Request      
GO111MODULE=on go generate
go: github.com/denisenkom/go-mssqldb@v0.0.0-20180314172330-6a30f4e59a44: reading https://proxy.golang.org/github.com/denisenkom/go-mssqldb/@v/v0.0.0-20180314172330-6a30f4e59a44.mod: 400 Bad Request      
make: *** [generate] Error 1

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Jul 7, 2019

@lunny

lunny approved these changes Jul 7, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Jul 7, 2019

@techknowlogick techknowlogick merged commit f88aa1d into go-gitea:master Jul 7, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details

jeffliu27 added a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.