Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set user search base field optional in LDAP (simple auth) edit page #6779

Merged
merged 2 commits into from Apr 28, 2019

Conversation

@ngourdon
Copy link
Contributor

commented Apr 27, 2019

fix #6548

@codecov-io

This comment has been minimized.

Copy link

commented Apr 27, 2019

Codecov Report

Merging #6779 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6779      +/-   ##
=========================================
+ Coverage   40.99%     41%   +<.01%     
=========================================
  Files         421     421              
  Lines       58054   58054              
=========================================
+ Hits        23802   23803       +1     
+ Misses      31086   31085       -1     
  Partials     3166    3166
Impacted Files Coverage Δ
modules/log/router.go 90% <0%> (-2.5%) ⬇️
modules/log/event.go 64.46% <0%> (-1.53%) ⬇️
modules/log/file.go 77.62% <0%> (+2.09%) ⬆️
models/unit.go 48.64% <0%> (+5.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81059a2...1df04e5. Read the comment docs.

@lafriks lafriks added the kind/bug label Apr 27, 2019

@lafriks lafriks added this to the 1.9.0 milestone Apr 27, 2019

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Apr 27, 2019

@lunny

lunny approved these changes Apr 28, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Apr 28, 2019

@techknowlogick

This comment has been minimized.

Copy link
Member

commented Apr 28, 2019

Make LG-TM work

@techknowlogick techknowlogick merged commit d29d97d into go-gitea:master Apr 28, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
@techknowlogick

This comment has been minimized.

Copy link
Member

commented Apr 28, 2019

Thanks for PR :) could you backport this to release/v1.8 branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
You can’t perform that action at this time.