Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix team edit API panic #6780

Merged
merged 2 commits into from Apr 27, 2019

Conversation

@ngourdon
Copy link
Contributor

commented Apr 27, 2019

fix #6777 and add tests for team API

Show resolved Hide resolved integrations/api_team_test.go Outdated
@lafriks

This comment has been minimized.

Copy link
Member

commented Apr 27, 2019

Thanks for adding tests 👍 small nit but otherwise LGTM

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Apr 27, 2019

@lafriks lafriks added this to the 1.9.0 milestone Apr 27, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Apr 27, 2019

Codecov Report

Merging #6780 into master will increase coverage by 0.22%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6780      +/-   ##
==========================================
+ Coverage   40.99%   41.22%   +0.22%     
==========================================
  Files         421      421              
  Lines       58054    58054              
==========================================
+ Hits        23802    23933     +131     
+ Misses      31086    30954     -132     
- Partials     3166     3167       +1
Impacted Files Coverage Δ
routers/api/v1/org/team.go 25.58% <100%> (+21.59%) ⬆️
modules/log/router.go 90% <0%> (-2.5%) ⬇️
modules/log/event.go 64.46% <0%> (-1.53%) ⬇️
routers/api/v1/api.go 70.42% <0%> (+1.74%) ⬆️
models/org_team.go 53.24% <0%> (+2.86%) ⬆️
models/access.go 66.87% <0%> (+5.09%) ⬆️
models/unit.go 67.56% <0%> (+24.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81059a2...f347d91. Read the comment docs.

undo change of copyright year
Co-Authored-By: ngourdon <31291059+ngourdon@users.noreply.github.com>

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Apr 27, 2019

@techknowlogick techknowlogick merged commit 4e31112 into go-gitea:master Apr 27, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
@techknowlogick

This comment has been minimized.

Copy link
Member

commented Apr 27, 2019

@ngourdon thanks for PR :) would you be able to backport this PR to the release/v1.8 branch?

@ngourdon ngourdon referenced this pull request Apr 28, 2019

Merged

Fix team edit API panic #6785

@ngourdon ngourdon deleted the ngourdon:fix-6777 branch Jun 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.