Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When mirroring we should set the remote to mirror #6824

Merged
merged 2 commits into from May 2, 2019

Conversation

@zeripath
Copy link
Contributor

commented May 1, 2019

My fix in #6593 didn't set the mirrors to be mirrors for fetching, which appears to have broken mirroring.

When adding the remote we should --mirror=fetch to set the refs correctly.

Fix #6783

@GiteaBot GiteaBot added the lgtm/need 1 label May 1, 2019

@codecov-io

This comment has been minimized.

Copy link

commented May 1, 2019

Codecov Report

Merging #6824 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6824      +/-   ##
==========================================
- Coverage   41.22%   41.21%   -0.01%     
==========================================
  Files         421      421              
  Lines       58118    58118              
==========================================
- Hits        23958    23955       -3     
- Misses      30987    30990       +3     
  Partials     3173     3173
Impacted Files Coverage Δ
models/repo_mirror.go 23.65% <0%> (ø) ⬆️
modules/log/event.go 64.46% <0%> (-1.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8979276...4ac185e. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels May 1, 2019

@lafriks

lafriks approved these changes May 2, 2019

@lafriks lafriks merged commit 159294f into go-gitea:master May 2, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
@lafriks

This comment has been minimized.

Copy link
Member

commented May 2, 2019

Please send backport

@zeripath

This comment has been minimized.

Copy link
Contributor Author

commented May 2, 2019

Can do that this evening in 10 hours time, but if wanted earlier feel free.

zeripath added a commit to zeripath/gitea that referenced this pull request May 2, 2019

@zeripath zeripath deleted the zeripath:fix-#6783-mirror-should-mirror branch May 2, 2019

@zeripath

This comment has been minimized.

Copy link
Contributor Author

commented May 2, 2019

Backport made.

techknowlogick added a commit that referenced this pull request May 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.