Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename LFS_JWT_SECRET cli option to include OAUTH2 as well #6826

Merged
merged 1 commit into from May 2, 2019

Conversation

5 participants
@techknowlogick
Copy link
Member

commented May 2, 2019

Fix #6810

@techknowlogick techknowlogick added this to the 1.9.0 milestone May 2, 2019

@techknowlogick techknowlogick changed the title Rename LFS_JWT_SECRET to include OAUTH2 as well Rename LFS_JWT_SECRET cli option to include OAUTH2 as well May 2, 2019

@codecov-io

This comment has been minimized.

Copy link

commented May 2, 2019

Codecov Report

Merging #6826 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6826      +/-   ##
=========================================
- Coverage   41.21%   41.2%   -0.01%     
=========================================
  Files         421     421              
  Lines       58118   58118              
=========================================
- Hits        23952   23949       -3     
- Misses      30993   30996       +3     
  Partials     3173    3173
Impacted Files Coverage Δ
modules/log/event.go 64.46% <0%> (-1.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e255df8...794ad45. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 label May 2, 2019

@sapk

sapk approved these changes May 2, 2019

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels May 2, 2019

@adelowo

adelowo approved these changes May 2, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels May 2, 2019

@techknowlogick techknowlogick merged commit 8979276 into go-gitea:master May 2, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details

@techknowlogick techknowlogick deleted the techknowlogick:fix-6810 branch May 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.