Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't post process commit summary in templates #6842

Merged
merged 6 commits into from May 5, 2019

Conversation

@mrsdizzie
Copy link
Contributor

commented May 3, 2019

Don't run summary through render/post process on certain list views where it is already expected to be a link to the individual commit. This avoids inconsistent UI in some cases.

Fixes #6809

Don't post process commit summary in templates
Don't run summary through render/post process to avoid it generating
links and breaking certain views where the summary is already expected
to be a link to the commit. For consistancy, disable processing of
summary in all locations.

Fixes #6809
@codecov-io

This comment has been minimized.

Copy link

commented May 3, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@9148e45). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6842   +/-   ##
=========================================
  Coverage          ?   41.14%           
=========================================
  Files             ?      425           
  Lines             ?    58484           
  Branches          ?        0           
=========================================
  Hits              ?    24061           
  Misses            ?    31238           
  Partials          ?     3185

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9148e45...6f57f88. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 label May 3, 2019

Do process title on diff page
On second thought, the title is often the only place a pull request
number will exists so do process it on the individual diff page. This
fixes the list view and still gives easy access to the PR link
@mrsdizzie

This comment has been minimized.

Copy link
Contributor Author

commented May 4, 2019

Also up for feedback if keeping certain auto generated links in the summary title is something that is a very desired feature.

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels May 5, 2019

@lafriks

lafriks approved these changes May 5, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels May 5, 2019

lunny and others added some commits May 5, 2019

@mrsdizzie mrsdizzie referenced this pull request May 5, 2019

Closed

make links more visibles #6844

2 of 8 tasks complete

techknowlogick added some commits May 5, 2019

@techknowlogick techknowlogick merged commit 00b8838 into go-gitea:master May 5, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
@zeripath

This comment has been minimized.

Copy link
Contributor

commented May 6, 2019

As @lunny says in the underlying issue, this should probably be backported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
You can’t perform that action at this time.