Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 500 when reviewer is deleted with integration tests #6856

Merged
merged 2 commits into from May 6, 2019

Conversation

@lunny
Copy link
Member

commented May 6, 2019

will fix #6797

@lunny lunny added this to the 1.9.0 milestone May 6, 2019

@lunny lunny changed the title fix 500 when reviewer is deleted with integration tests Fix 500 when reviewer is deleted with integration tests May 6, 2019

@lunny lunny force-pushed the lunny:lunny/fix_removed_reviewer branch from 93a323c to fdbd10c May 6, 2019

@codecov-io

This comment has been minimized.

Copy link

commented May 6, 2019

Codecov Report

Merging #6856 into master will increase coverage by 0.03%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6856      +/-   ##
==========================================
+ Coverage   41.14%   41.17%   +0.03%     
==========================================
  Files         425      425              
  Lines       58484    58489       +5     
==========================================
+ Hits        24061    24082      +21     
+ Misses      31236    31220      -16     
  Partials     3187     3187
Impacted Files Coverage Δ
models/issue_comment.go 47.48% <100%> (+0.57%) ⬆️
routers/repo/issue.go 35.87% <42.85%> (+0.29%) ⬆️
models/unit.go 62.16% <0%> (-5.41%) ⬇️
routers/repo/view.go 42.02% <0%> (-1.02%) ⬇️
routers/user/home.go 49.89% <0%> (+0.63%) ⬆️
routers/repo/pull.go 36.86% <0%> (+0.72%) ⬆️
models/issue_comment_list.go 75.62% <0%> (+1.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dab38c3...ed253d8. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 label May 6, 2019

@adelowo

adelowo approved these changes May 6, 2019

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels May 6, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels May 6, 2019

@lunny lunny merged commit 2382f1b into go-gitea:master May 6, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details

lunny added a commit that referenced this pull request May 6, 2019

@lunny lunny deleted the lunny:lunny/fix_removed_reviewer branch May 6, 2019

lafriks added a commit that referenced this pull request May 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
You can’t perform that action at this time.