Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config ui error about cache ttl #6861

Merged
merged 1 commit into from May 6, 2019

Conversation

@lunny
Copy link
Member

commented May 6, 2019

Will fix #6730 and replace #6770. @adelowo

@lunny lunny added the kind/ui label May 6, 2019

@lunny lunny added this to the 1.9.0 milestone May 6, 2019

@lunny lunny added the backport/v1.8 label May 6, 2019

@lunny lunny force-pushed the lunny:lunny/fix_config_ui branch from ee108e4 to 4f65f10 May 6, 2019

@adelowo

adelowo approved these changes May 6, 2019

@codecov-io

This comment has been minimized.

Copy link

commented May 6, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@5d5eae6). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6861   +/-   ##
=========================================
  Coverage          ?   41.18%           
=========================================
  Files             ?      425           
  Lines             ?    58490           
  Branches          ?        0           
=========================================
  Hits              ?    24089           
  Misses            ?    31214           
  Partials          ?     3187
Impacted Files Coverage Δ
routers/admin/admin.go 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d5eae6...4f65f10. Read the comment docs.

@lafriks

lafriks approved these changes May 6, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels May 6, 2019

@lafriks lafriks merged commit 01ebd52 into go-gitea:master May 6, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details

@lunny lunny deleted the lunny:lunny/fix_config_ui branch May 6, 2019

lunny added a commit to lunny/gitea that referenced this pull request May 6, 2019

lafriks added a commit that referenced this pull request May 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
You can’t perform that action at this time.