Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 404 when send pull request some situation #6871

Merged
merged 5 commits into from May 7, 2019

Conversation

@lunny
Copy link
Member

commented May 7, 2019

With integration tests and should fix #6302

@lunny lunny added this to the 1.9.0 milestone May 7, 2019

Show resolved Hide resolved routers/api/v1/repo/pull.go Outdated

@GiteaBot GiteaBot added the lgtm/need 2 label May 7, 2019

Update routers/api/v1/repo/pull.go
Co-Authored-By: lunny <xiaolunwen@gmail.com>
Show resolved Hide resolved routers/api/v1/repo/pull.go Outdated
Show resolved Hide resolved routers/repo/pull.go Outdated
Show resolved Hide resolved routers/repo/pull.go Outdated

zeripath and others added some commits May 7, 2019

Update routers/api/v1/repo/pull.go
Co-Authored-By: lunny <xiaolunwen@gmail.com>
Update routers/repo/pull.go
Co-Authored-By: lunny <xiaolunwen@gmail.com>
Update routers/repo/pull.go
Co-Authored-By: lunny <xiaolunwen@gmail.com>
@zeripath

This comment has been minimized.

Copy link
Contributor

commented May 7, 2019

@lunny, would it be possible to write a document somewhere explaining what the permissions should be doing things? (This isn't the PR for that I know but I think it's a good example of one where we're not very clear about what permissions things should have.)

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels May 7, 2019

@codecov-io

This comment has been minimized.

Copy link

commented May 7, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@9139f35). Click here to learn what that means.
The diff coverage is 10%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6871   +/-   ##
=========================================
  Coverage          ?   41.33%           
=========================================
  Files             ?      432           
  Lines             ?    59532           
  Branches          ?        0           
=========================================
  Hits              ?    24607           
  Misses            ?    31689           
  Partials          ?     3236
Impacted Files Coverage Δ
routers/repo/pull.go 36.43% <11.11%> (ø)
routers/api/v1/repo/pull.go 36.19% <9.09%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9139f35...00211d8. Read the comment docs.

@lafriks

lafriks approved these changes May 7, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels May 7, 2019

@techknowlogick techknowlogick merged commit 9f18b23 into go-gitea:master May 7, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
@zeripath

This comment has been minimized.

Copy link
Contributor

commented May 7, 2019

@lunny are you able to backport?

@lunny lunny deleted the lunny:lunny/fix_create_pull branch May 7, 2019

lunny added a commit to lunny/gitea that referenced this pull request May 7, 2019

@lunny

This comment has been minimized.

Copy link
Member Author

commented May 7, 2019

@zeripath I think that's a good idea. I will do that.

techknowlogick added a commit that referenced this pull request May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
You can’t perform that action at this time.