Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Support new file/upload file buttons on empty repo home page #6918

Open
wants to merge 5 commits into
base: master
from

Conversation

7 participants
@lunny
Copy link
Member

commented May 12, 2019

image

lunny added some commits May 11, 2019

@lunny lunny added the kind/feature label May 12, 2019

@xf-

This comment has been minimized.

Copy link
Contributor

commented May 12, 2019

Maybe add the right portion of the normal bar on the top left side and set Download on disabled:
image

This would be a much more constant UI and user expierence

lunny added some commits May 12, 2019

@lunny

This comment has been minimized.

Copy link
Member Author

commented May 12, 2019

@xf- I don't think that's better than current design.

@codecov-io

This comment has been minimized.

Copy link

commented May 12, 2019

Codecov Report

Merging #6918 into master will decrease coverage by 0.02%.
The diff coverage is 40.9%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6918      +/-   ##
=========================================
- Coverage   41.42%   41.4%   -0.03%     
=========================================
  Files         440     440              
  Lines       59738   59792      +54     
=========================================
+ Hits        24749   24759      +10     
- Misses      31752   31793      +41     
- Partials     3237    3240       +3
Impacted Files Coverage Δ
routers/routes/routes.go 82.39% <ø> (ø) ⬆️
routers/api/v1/repo/file.go 67.42% <0%> (-0.78%) ⬇️
routers/repo/view.go 42.39% <0%> (-0.65%) ⬇️
routers/repo/editor.go 25.66% <19.04%> (+0.46%) ⬆️
modules/repofiles/temp_repo.go 63.91% <44.44%> (-6.6%) ⬇️
modules/context/repo.go 56.97% <50%> (-0.03%) ⬇️
modules/repofiles/update.go 40.25% <50.66%> (+0.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13583a6...a2acf9e. Read the comment docs.

Name: branch,
if t.repo.IsEmpty {
if _, stderr, err := process.GetManager().ExecTimeout(5*time.Minute,
fmt.Sprintf("Clone (git clone -s --bare): %s", t.basePath),

This comment has been minimized.

Copy link
@techknowlogick

techknowlogick May 15, 2019

Member

Can you move this command exec to git package?

} else {
if _, stderr, err := process.GetManager().ExecTimeout(5*time.Minute,
fmt.Sprintf("Clone (git clone -s --bare): %s", t.basePath),
"git", "clone", "-s", "--bare", "-b", branch, t.repo.RepoPath(), t.basePath); err != nil {

This comment has been minimized.

Copy link
@techknowlogick
t.basePath,
fmt.Sprintf("commitTree (git commit-tree): %s", t.basePath),
env,
"git", "commit-tree", treeHash, "-m", message)

This comment has been minimized.

Copy link
@techknowlogick
@silverwind

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

Think I'd also prefer having those button beside the clone URL. As an alternative, a bit less padding could also work. Or maybe even move the buttons into the header on the top-right.

@techknowlogick

This comment has been minimized.

Copy link
Member

commented May 16, 2019

I like the idea of having the buttons next to clone, because that is what it is like when files are in the repo. So it would keep things the same for users.

If we don't have it next to clone, I like @silverwind's alternative of having less padding.

A third alternative is to make the buttons Giant, so they fill up the empty whitespace.

Here is a screenshot of what GitHub does, but I don't like how they made the create/upload actions text:
Screen Shot 2019-05-16 at 3 27 52 PM

(sidenote: thanks @silverwind for GitHub dark theme)

@silverwind

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

I like the idea of subtle text links. No need for big distracting buttons when most people will probably want to initizalize a repo through other means.

@mrsdizzie

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

Agree it seems odd not to just have it in the same spot as every other page. Consistency across pages seems more important than anything else for this case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.