Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add work path CLI option #6922

Merged
merged 8 commits into from May 14, 2019

Conversation

5 participants
@zeripath
Copy link
Contributor

commented May 12, 2019

As mentioned in #6855 the use of environment variables to configure gitea - although common practice - is confusing and frustrating for non-docker users. Environment variables are somewhat opaque to most users and can't easily be inferred from the command.

This PR adds a new option to the main command-line allowing you to set the work-path, overriding the GITEA_WORK_DIR variable and build defined AppWorkDir as necessary.

zeripath added some commits May 12, 2019

Add work path CLI option
Makes it possible to set the work path as a CLI option instead of
relying on environment variables which are somewhat opaque
@techknowlogick

This comment has been minimized.

Copy link
Member

commented May 12, 2019

contrib/pr/checkout.go:46 needs to be updated, but otherwise this looks good.

zeripath added some commits May 13, 2019

@zeripath

This comment has been minimized.

Copy link
Contributor Author

commented May 13, 2019

Sorry this is turning into a game of whack-a-mole...

@codecov-io

This comment has been minimized.

Copy link

commented May 13, 2019

Codecov Report

Merging #6922 into master will increase coverage by <.01%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6922      +/-   ##
=========================================
+ Coverage    41.4%   41.4%   +<.01%     
=========================================
  Files         441     441              
  Lines       59729   59732       +3     
=========================================
+ Hits        24730   24735       +5     
+ Misses      31761   31757       -4     
- Partials     3238    3240       +2
Impacted Files Coverage Δ
modules/setting/setting.go 47.41% <25%> (-0.26%) ⬇️
modules/log/event.go 65.98% <0%> (+1.52%) ⬆️
models/unit.go 67.56% <0%> (+5.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 488d346...d8634e9. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels May 14, 2019

@techknowlogick techknowlogick merged commit e55c874 into go-gitea:master May 14, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details

@zeripath zeripath deleted the zeripath:add-work-path-option branch May 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.