Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchRepositoryByName improvements and unification (#6897) #7002

Merged

Conversation

@lafriks
Copy link
Member

commented May 20, 2019

Backport #6897, should fix #7001

@lafriks lafriks requested a review from zeripath May 20, 2019

@lafriks lafriks added the kind/bug label May 20, 2019

@lafriks lafriks added this to the 1.8.2 milestone May 20, 2019

models/repo_list_test.go Outdated Show resolved Hide resolved
integrations/api_repo_test.go Outdated Show resolved Hide resolved
integrations/api_repo_test.go Outdated Show resolved Hide resolved
integrations/api_repo_test.go Outdated Show resolved Hide resolved
@zeripath

This comment has been minimized.

Copy link
Contributor

commented May 20, 2019

I was literally just doing this... 2 public repos were added between 1.9 and 1.8 so you need to change a few numbers in the test cases.

@zeripath

This comment has been minimized.

Copy link
Contributor

commented May 20, 2019

Probably will need @mrsdizzie 's additional fix for collaborators on team repositories.

@mrsdizzie

This comment has been minimized.

Copy link
Contributor

commented May 20, 2019

That was already back ported in #6968 and so things should just work when this change starts listing those repos in a users dashboard

lafriks and others added some commits May 20, 2019

Update tests
Co-Authored-By: zeripath <art27@cantab.net>
Update tests
Co-Authored-By: zeripath <art27@cantab.net>
Update tests
Co-Authored-By: zeripath <art27@cantab.net>
@zeripath

This comment has been minimized.

Copy link
Contributor

commented May 21, 2019

Make lg-tm work

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels May 21, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels May 21, 2019

@lafriks lafriks merged commit 608f46e into go-gitea:release/v1.8 May 21, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.