Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install page - Handle invalid administrator username better #7060

Merged
merged 3 commits into from May 28, 2019

Conversation

@zeripath
Copy link
Contributor

commented May 27, 2019

Fixes #1409
Fixes #6954

Detecting if the administrator username is invalid before creating the initial config and global init means that the user can change this - previously this would cause an unending loop.

It also checks the email is not empty.

@zeripath zeripath added the kind/bug label May 27, 2019

@zeripath zeripath added this to the 1.9.0 milestone May 27, 2019

@codecov-io

This comment has been minimized.

Copy link

commented May 27, 2019

Codecov Report

Merging #7060 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7060      +/-   ##
==========================================
- Coverage   41.45%   41.43%   -0.02%     
==========================================
  Files         442      442              
  Lines       59623    59643      +20     
==========================================
  Hits        24716    24716              
- Misses      31676    31696      +20     
  Partials     3231     3231
Impacted Files Coverage Δ
routers/install.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69d81b6...ce0018b. Read the comment docs.

@lunny

lunny approved these changes May 28, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels May 28, 2019

@zeripath zeripath merged commit bd9ed96 into go-gitea:master May 28, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details

@zeripath zeripath deleted the zeripath:install-page branch May 28, 2019

zeripath added a commit to zeripath/gitea that referenced this pull request May 28, 2019

Install page - Handle invalid administrator username better (go-gitea…
…#7060)

* Install page - detect invalid admin username before installing

* Also fix go-gitea#6954

zeripath added a commit that referenced this pull request May 28, 2019

Install page - Handle invalid administrator username better (#7060) (#…
…7063)

* Install page - detect invalid admin username before installing

* Also fix #6954

jeffliu27 added a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019

Install page - Handle invalid administrator username better (go-gitea…
…#7060)

* Install page - detect invalid admin username before installing

* Also fix go-gitea#6954
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
You can’t perform that action at this time.