Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix GCArgs load from ini #7156

Merged
merged 1 commit into from Jun 8, 2019

Conversation

@lunny
Copy link
Member

commented Jun 8, 2019

Should fix #5593

@lunny lunny added the kind/bug label Jun 8, 2019

@lunny lunny added this to the 1.9.0 milestone Jun 8, 2019

@lunny lunny added the backport/v1.8 label Jun 8, 2019

@adelowo

adelowo approved these changes Jun 8, 2019

@GiteaBot GiteaBot added the lgtm/need 1 label Jun 8, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Jun 8, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@ca58eee). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7156   +/-   ##
=========================================
  Coverage          ?   41.64%           
=========================================
  Files             ?      447           
  Lines             ?    60888           
  Branches          ?        0           
=========================================
  Hits              ?    25354           
  Misses            ?    32245           
  Partials          ?     3289
Impacted Files Coverage Δ
modules/setting/git.go 52.17% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca58eee...ae98f25. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Jun 8, 2019

@lunny lunny merged commit 6fb31a5 into go-gitea:master Jun 8, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details

@lunny lunny deleted the lunny:lunny/fix_gcargs branch Jun 8, 2019

lunny added a commit to lunny/gitea that referenced this pull request Jun 8, 2019

@lunny lunny added the backport/done label Jun 8, 2019

techknowlogick added a commit that referenced this pull request Jun 8, 2019

jeffliu27 added a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.