Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always set userID on LFS authentication #7224

Merged
merged 3 commits into from Jun 17, 2019

Conversation

@zeripath
Copy link
Contributor

commented Jun 16, 2019

Fix #5478 on 1.8
Fix #7219 on 1.8

These issues are fixed on 1.9 through #6993 which is too major a change to backport to 1.8.

zeripath added some commits Jun 16, 2019

@zeripath

This comment has been minimized.

Copy link
Contributor Author

commented Jun 16, 2019

OK, the first commit could still lead to problems with getting LFS files from public repos using deploy keys that are not associated with this deploy key.

I think deploy keys should only be used to read repositories that they are associated with, not just any repository - and in fact #6993 did this.

The second commit in this PR replicates this change of semantics.

@zeripath zeripath added this to the 1.8.3 milestone Jun 16, 2019

@zeripath zeripath added the kind/bug label Jun 16, 2019

@lunny

lunny approved these changes Jun 17, 2019

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Jun 17, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Jun 17, 2019

@lafriks lafriks merged commit 5d1a8d2 into go-gitea:release/v1.8 Jun 17, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details

@zeripath zeripath deleted the zeripath:fix-5478-7219-on-1.8 branch Jun 17, 2019

@zeripath zeripath referenced this pull request Jun 18, 2019
2 of 7 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.