Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use vendors when go generate #7340

Merged
merged 4 commits into from Jul 7, 2019

Conversation

4 participants
@lunny
Copy link
Member

commented Jul 2, 2019

Since we have store all the dependencies on vendor, I think we should also use them when run go generate. This will speed up make generate process and reduce failure possible when CI runs.

@lunny lunny added the kind/build label Jul 2, 2019

@lunny lunny added this to the 1.9.0 milestone Jul 2, 2019

Show resolved Hide resolved Makefile

@GiteaBot GiteaBot added the lgtm/need 2 label Jul 2, 2019

@lunny

This comment has been minimized.

Copy link
Member Author

commented Jul 2, 2019

@techknowlogick Maybe we should do that on v1.10, I will move this to v1.10 so that we could not change the minimal Golang requirement on v1.9.

@lunny lunny modified the milestones: 1.9.0, 1.10.0 Jul 2, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Jul 2, 2019

Codecov Report

Merging #7340 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7340      +/-   ##
==========================================
+ Coverage   41.23%   41.23%   +<.01%     
==========================================
  Files         468      468              
  Lines       63337    63337              
==========================================
+ Hits        26114    26116       +2     
- Misses      33812    33813       +1     
+ Partials     3411     3408       -3
Impacted Files Coverage Δ
models/unit.go 62.16% <0%> (-5.41%) ⬇️
modules/log/event.go 64.61% <0%> (-1.03%) ⬇️
models/gpg_key.go 56.66% <0%> (+0.83%) ⬆️
modules/process/manager.go 81.15% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f369788...a49cfed. Read the comment docs.

lunny added some commits Jul 2, 2019

@lunny lunny force-pushed the lunny:lunny/fix_generate branch from c86e8ee to 05f2153 Jul 7, 2019

@techknowlogick techknowlogick merged commit 87404d7 into go-gitea:master Jul 7, 2019

1 of 2 checks passed

approvals/lgtm 0 of 2 required approvals granted
continuous-integration/drone/pr Build is passing
Details

@lunny lunny deleted the lunny:lunny/fix_generate branch Jul 7, 2019

jeffliu27 added a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019

Use vendors when go generate (go-gitea#7340)
* use vendors when go generate

* update docs about golang minimal requirement from 1.9 to 1.11

* fix build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.