Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix api route #7346

Merged
merged 1 commit into from Jul 3, 2019

Conversation

6 participants
@lunny
Copy link
Member

commented Jul 3, 2019

As title.

@lunny lunny added this to the 1.9.0 milestone Jul 3, 2019

@lunny lunny requested a review from techknowlogick Jul 3, 2019

@GiteaBot GiteaBot added the lgtm/need 1 label Jul 3, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Jul 3, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Jul 3, 2019

Codecov Report

Merging #7346 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7346      +/-   ##
==========================================
- Coverage   41.25%   41.25%   -0.01%     
==========================================
  Files         467      467              
  Lines       63291    63291              
==========================================
- Hits        26112    26108       -4     
- Misses      33762    33767       +5     
+ Partials     3417     3416       -1
Impacted Files Coverage Δ
routers/api/v1/api.go 71.36% <100%> (ø) ⬆️
models/unit.go 62.16% <0%> (-5.41%) ⬇️
modules/log/event.go 64.61% <0%> (-1.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68ec7b8...06f696b. Read the comment docs.

@zeripath zeripath merged commit b5aa7f7 into go-gitea:master Jul 3, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
@zeripath

This comment has been minimized.

Copy link
Contributor

commented Jul 3, 2019

Please send backport

@lunny lunny deleted the lunny:lunny/fix_hooks_routes branch Jul 3, 2019

lunny added a commit to lunny/gitea that referenced this pull request Jul 3, 2019

@lunny lunny referenced this pull request Jul 3, 2019

Merged

Fix api route (#7346) #7347

@lunny lunny added the backport/done label Jul 3, 2019

techknowlogick added a commit that referenced this pull request Jul 3, 2019

stertingen added a commit to stertingen/gitea that referenced this pull request Jul 3, 2019

@Cherrg

This comment has been minimized.

Copy link
Contributor

commented Jul 4, 2019

i don't know why, but since merging this drone build seems to be broken

@techknowlogick

This comment has been minimized.

Copy link
Member

commented Jul 4, 2019

@Cherrg fail is due to an upstream dependency not related to this PR

@Cherrg

This comment has been minimized.

Copy link
Contributor

commented Jul 4, 2019

ok, only looked what was merged before it was broken :)

unfortunately i cant reproduce this on my local machine to track down the error

jeffliu27 added a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.