Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vendor #7394

Merged
merged 1 commit into from Jul 9, 2019

Conversation

@lunny
Copy link
Member

commented Jul 9, 2019

The previous date is wrong in fact.
How did I get the correct datetime on version.

STEP 1:

+replace github.com/denisenkom/go-mssqldb => github.com/denisenkom/go-mssqldb v0.0.0-20180314172330-6a30f4e59a44
-replace github.com/denisenkom/go-mssqldb => github.com/denisenkom/go-mssqldb 6a30f4e59a44

STEP 2:

make vendor

@lunny lunny requested a review from sapk Jul 9, 2019

@lunny lunny referenced this pull request Jul 9, 2019

Closed

Fix vendor #7371

@lunny lunny added this to the 1.10.0 milestone Jul 9, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Jul 9, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@46d3d10). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #7394   +/-   ##
========================================
  Coverage          ?   41.2%           
========================================
  Files             ?     469           
  Lines             ?   63536           
  Branches          ?       0           
========================================
  Hits              ?   26178           
  Misses            ?   33937           
  Partials          ?    3421

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46d3d10...cb0f081. Read the comment docs.

@lafriks

lafriks approved these changes Jul 9, 2019

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Jul 9, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Jul 9, 2019

@lunny lunny merged commit f03e5b7 into go-gitea:master Jul 9, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details

@lunny lunny deleted the lunny:lunny/fix_vendor branch Jul 9, 2019

lunny added a commit to lunny/gitea that referenced this pull request Jul 9, 2019

@lunny lunny referenced this pull request Jul 9, 2019

Merged

Fix vendor (#7394) #7396

@lunny lunny added the backport/done label Jul 9, 2019

techknowlogick added a commit that referenced this pull request Jul 9, 2019

@sapk

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

That my bad when I was bisecting to find the blocking commit, I discover that the date is purely informative in the go.mod (at least to get the corresponding files) so I just change the commit id but I fotgot to update the date for the final fix. Sorry.

jeffliu27 added a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.