Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md with information about DCO #7397

Open
wants to merge 2 commits into
base: master
from

Conversation

5 participants
@@ -77,7 +77,7 @@ Here's how to run the test suite:
creates (a default AWS or GCE disk size won't work -- see
[#6243](https://github.com/go-gitea/gitea/issues/6243)).
- Change into the base directory of your copy of the gitea repository,
and run `drone exec --local --build-event pull_request`.
and run `drone exec --event pull_request`.

This comment has been minimized.

Copy link
@techknowlogick

techknowlogick Jul 9, 2019

Author Member

This line is unrelated to this PR, but as it is small rather than open a second PR for just this I have included here. If there is opposition to including this line in this PR please comment here and I will open a second PR for this line.

This comment has been minimized.

Copy link
@sapk

sapk Jul 9, 2019

Member

I think there is an open issue related to that. I will look into it.

This comment has been minimized.

Copy link
@sapk

sapk Jul 9, 2019

Member

It was closed by an other PR but this one complete it #7350

@GiteaBot GiteaBot added the lgtm/need 2 label Jul 9, 2019

@sapk

sapk approved these changes Jul 9, 2019

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Jul 9, 2019

@sapk

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

The build failure /bin/sh: 1: ./migrations.test: Text file busy seems not related.

Show resolved Hide resolved CONTRIBUTING.md Outdated
@zeripath

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2019

Otherwise lgtm

Update CONTRIBUTING.md
Co-Authored-By: zeripath <art27@cantab.net>
If you set your `user.name` and `user.email` git configs, you can add the
line to the end of your commit automatically with `git commit -s`.

We assume in good faith that the information you provide is legally biding.

This comment has been minimized.

Copy link
@mrsdizzie

mrsdizzie Jul 9, 2019

Contributor
Suggested change
We assume in good faith that the information you provide is legally biding.
We assume in good faith that the information you provide adheres to the [DCO](DCO), and won't request more personal information than provided for contributions.

Not sure if this change makes sense with the DCO, but also we do allow pseudonyms and we probably aren't assuming they are 100% legally binding (and in many cases as the contributions aren't on a large scale to wonder if they were taken from anywhere else). Also I think with the information above most people who don't mind will do the sign off with legal name as they do now and people who don't want to won't

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.