Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jQuery 3 #7425

Merged
merged 6 commits into from Jul 12, 2019

Conversation

7 participants
@techknowlogick
Copy link
Member

commented Jul 11, 2019

Fix #7422

techknowlogick added some commits Jul 11, 2019

@techknowlogick techknowlogick added this to the 1.10.0 milestone Jul 11, 2019

@techknowlogick techknowlogick changed the title jquery 3 jQuery 3 Jul 11, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Jul 11, 2019

Codecov Report

Merging #7425 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7425   +/-   ##
=======================================
  Coverage   41.19%   41.19%           
=======================================
  Files         469      469           
  Lines       63544    63544           
=======================================
  Hits        26174    26174           
  Misses      33948    33948           
  Partials     3422     3422

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 072bdfa...bd94920. Read the comment docs.

@lunny

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

You should remove public/vendor/plugins/jquery/.DS_Store

@techknowlogick

This comment has been minimized.

Copy link
Member Author

commented Jul 11, 2019

@lunny Thanks for noticing :) Looks like when I changed to a new computer I didn't update global gitignore file.

@silverwind

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

Why is jquery.migrate included? Would prefer if we can do without it.

techknowlogick added some commits Jul 11, 2019

@techknowlogick

This comment has been minimized.

Copy link
Member Author

commented Jul 12, 2019

@silverwind I too would prefer without it, but sadly semantic UI (at least the version we use) has deprecated code (and an upgrade for that should come in a different PR). There is also several places in index.js that need to be updated (but I was going to save that for a second PR too).

@silverwind

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2019

Gah, goddamn semantic holding us back, okay.

@silverwind
Copy link
Contributor

left a comment

LGTM based on diff

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Jul 12, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Jul 12, 2019

@lafriks lafriks merged commit efaee46 into go-gitea:master Jul 12, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
@lunny

This comment has been minimized.

Copy link
Member

commented Jul 12, 2019

Could this be back ported to v1.9 since it's related with security. Somebody reported me that.

techknowlogick added a commit to techknowlogick/gitea that referenced this pull request Jul 12, 2019

@techknowlogick techknowlogick deleted the techknowlogick:jquery-3 branch Jul 12, 2019

zeripath added a commit that referenced this pull request Jul 12, 2019

jeffliu27 added a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019

jQuery 3 (go-gitea#7425)
* jquery 3

* use most recent version of migrate plugin

* Delete .DS_Store

* update service worker in case anyone has old version of jquery cached
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.