Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drone/docker: prepare multi-arch release + provide arm64 image #7571

Merged
merged 7 commits into from Jul 24, 2019

Conversation

@sapk
Copy link
Member

commented Jul 22, 2019

Following #7480 this PR make the current docker release suffixed by -linux-amd64 and add a manifest pipeline linking the default latest and tagged version to corresponding arch.

Later we will only need to add specific docker-os-arch pipeline (+ manifest) to add a supported arch.

This PR is based on what the drone plugin does:
https://github.com/drone-plugins/drone-docker/blob/master/docker/docker/manifest.tmpl
https://github.com/drone-plugins/drone-docker/blob/master/.drone.yml#L303

.drone.yml Show resolved Hide resolved

@lunny lunny added the kind/build label Jul 23, 2019

sapk added 3 commits Jul 23, 2019
@sapk

This comment has been minimized.

Copy link
Member Author

commented Jul 23, 2019

I don't know why but drone doesn't like the file: https://drone.gitea.io/go-gitea/gitea/11012
I check lint via cli (drone version 1.1.2) and it doesn't report me anything.
drone exec --event pull_request also work.
solution found by @techknowlogick

@techknowlogick

This comment has been minimized.

Copy link
Member

commented Jul 23, 2019

notify pipeline depends on docker

@sapk

This comment has been minimized.

Copy link
Member Author

commented Jul 23, 2019

@techknowlogick Thx it works now.

@sapk sapk changed the title drone/docker: prepare multi-arch release drone/docker: prepare multi-arch release + provide arm64 image Jul 24, 2019

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Jul 24, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Jul 24, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Jul 24, 2019

Codecov Report

Merging #7571 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7571   +/-   ##
=======================================
  Coverage   41.24%   41.24%           
=======================================
  Files         469      469           
  Lines       63608    63608           
=======================================
  Hits        26236    26236           
  Misses      33952    33952           
  Partials     3420     3420

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 635e7b3...1267efd. Read the comment docs.

@techknowlogick techknowlogick merged commit d4667a4 into go-gitea:master Jul 24, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details

@sapk sapk deleted the sapk-fork:drone-docker-multi-arch branch Jul 24, 2019

sapk added a commit to sapk-fork/gitea that referenced this pull request Aug 15, 2019
drone/docker: prepare multi-arch release + provide arm64 image (go-gi…
…tea#7571)

* drone/docker: prepare multi-arch release

* Add docker-linux-arm64 pipeline

* add arm 64 build to manifest

* tag dry-run + indent

* Fix notify dependency
techknowlogick added a commit that referenced this pull request Aug 15, 2019
drone/docker: prepare multi-arch release + provide arm64 image (#7571) (
#7884)

* drone/docker: prepare multi-arch release

* Add docker-linux-arm64 pipeline

* add arm 64 build to manifest

* tag dry-run + indent

* Fix notify dependency

@lunny lunny added this to the 1.10.0 milestone Aug 16, 2019

@lunny lunny added the backport/done label Aug 19, 2019

aswild added a commit to aswild/gitea that referenced this pull request Aug 25, 2019
Merge tag 'v1.9.2' into wild/v1.9
* BUGFIXES
  * Fix wrong sender when send slack webhook (go-gitea#7918) (go-gitea#7924)
  * Upload support text/plain; charset=utf8 (go-gitea#7899)
  * Lfs/lock: round locked_at timestamp to second (go-gitea#7872) (go-gitea#7875)
  * Fix non existent milestone with 500 error (go-gitea#7867) (go-gitea#7873)
* SECURITY
  * Fix No PGP signature on 1.9.1 tag (go-gitea#7874)
  * Release built with go 1.12.9 to fix security fixes in golang std lib, ref: https://groups.google.com/forum/#!msg/golang-announce/oeMaeUnkvVE/a49yvTLqAAAJ
* ENHANCEMENT
  * Fix pull creation with empty changes (go-gitea#7920) (go-gitea#7926)
* BUILD
  * Drone/docker: prepare multi-arch release + provide arm64 image (go-gitea#7571) (go-gitea#7884)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
You can’t perform that action at this time.