Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct wrong datetime format for git #7689

Merged

Conversation

@zeripath
Copy link
Contributor

commented Jul 31, 2019

The previous code used time.UnixDate which although initially thought to be the correct format for git's datestamp is incorrect. This PR changes this to use time.RFC3339 which is a subset of ISO8601 and should be interpreted correctly git.

Fix #7373

@zeripath zeripath added this to the 1.10.0 milestone Jul 31, 2019

@sapk
sapk approved these changes Jul 31, 2019
@codecov-io

This comment has been minimized.

Copy link

commented Jul 31, 2019

Codecov Report

Merging #7689 into master will increase coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7689      +/-   ##
==========================================
+ Coverage   41.24%   41.25%   +<.01%     
==========================================
  Files         471      471              
  Lines       63754    63754              
==========================================
+ Hits        26295    26301       +6     
+ Misses      34027    34020       -7     
- Partials     3432     3433       +1
Impacted Files Coverage Δ
modules/git/repo_tree.go 41.26% <0%> (ø) ⬆️
modules/repofiles/temp_repo.go 70.5% <100%> (ø) ⬆️
models/repo_list.go 73.09% <0%> (+1.01%) ⬆️
modules/log/event.go 65.64% <0%> (+1.02%) ⬆️
models/unit.go 67.56% <0%> (+5.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9b4c81...690e5b1. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Jul 31, 2019

@techknowlogick techknowlogick merged commit a4b7a4f into go-gitea:master Jul 31, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
@techknowlogick

This comment has been minimized.

Copy link
Member

commented Jul 31, 2019

Please send backport :)

@zeripath zeripath deleted the zeripath:use-rfc3339-for-git-date-stamps branch Jul 31, 2019

zeripath added a commit to zeripath/gitea that referenced this pull request Jul 31, 2019
zeripath added a commit that referenced this pull request Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
You can’t perform that action at this time.