Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix approvals counting #7757

Merged
merged 8 commits into from Aug 7, 2019

Conversation

@lunny
Copy link
Member

commented Aug 5, 2019

will fix #7680

@lunny lunny added this to the 1.10.0 milestone Aug 5, 2019

@lafriks
lafriks approved these changes Aug 5, 2019

@GiteaBot GiteaBot added the lgtm/need 1 label Aug 5, 2019

@lafriks

This comment has been minimized.

Copy link
Member

commented Aug 5, 2019

unit test seams to fail

lunny added 2 commits Aug 5, 2019

@lunny lunny force-pushed the lunny:lunny/fix_approvals_counting branch from 9b251e6 to 77a5c45 Aug 5, 2019

fmt
@codecov-io

This comment has been minimized.

Copy link

commented Aug 5, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@2594693). Click here to learn what that means.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7757   +/-   ##
=========================================
  Coverage          ?   41.32%           
=========================================
  Files             ?      473           
  Lines             ?    63831           
  Branches          ?        0           
=========================================
  Hits              ?    26378           
  Misses            ?    34014           
  Partials          ?     3439
Impacted Files Coverage Δ
models/org_team.go 52.49% <83.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2594693...10b6c81. Read the comment docs.

lafriks and others added 2 commits Aug 5, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Aug 6, 2019

lunny and others added 2 commits Aug 6, 2019
@sapk
sapk approved these changes Aug 7, 2019
@lafriks

This comment has been minimized.

Copy link
Member

commented Aug 7, 2019

LG-TM ;)

@lafriks lafriks merged commit c832f0e into go-gitea:master Aug 7, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details

@lunny lunny deleted the lunny:lunny/fix_approvals_counting branch Aug 7, 2019

lunny added a commit to lunny/gitea that referenced this pull request Aug 7, 2019
Fix approvals counting (go-gitea#7757)
* fix approvals counting

* fix tests

* fmt

@lunny lunny added the backport/done label Aug 7, 2019

lunny added a commit that referenced this pull request Aug 7, 2019
Fix approvals counting (#7757) (#7777)
* fix approvals counting

* fix tests

* fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
You can’t perform that action at this time.