Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rename failed when rewrite public keys #7761

Merged
merged 3 commits into from Aug 6, 2019

Conversation

@lunny
Copy link
Member

commented Aug 5, 2019

Should fix #7755 . We should close the files before rename it.

@lunny lunny added this to the 1.10.0 milestone Aug 5, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Aug 5, 2019

Codecov Report

Merging #7761 into master will decrease coverage by <.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7761      +/-   ##
==========================================
- Coverage   41.27%   41.27%   -0.01%     
==========================================
  Files         473      473              
  Lines       63872    63874       +2     
==========================================
- Hits        26365    26363       -2     
- Misses      34070    34073       +3     
- Partials     3437     3438       +1
Impacted Files Coverage Δ
models/ssh_key.go 49.24% <66.66%> (ø) ⬆️
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️
modules/log/event.go 64.61% <0%> (-1.03%) ⬇️
models/repo_list.go 73.09% <0%> (+1.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d8915a...923381b. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 label Aug 5, 2019

@lafriks
lafriks approved these changes Aug 5, 2019

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Aug 5, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Aug 6, 2019

@lunny

This comment has been minimized.

Copy link
Member Author

commented Aug 6, 2019

make L-G-T-M work

@lunny lunny merged commit 4328d8e into go-gitea:master Aug 6, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details

@lunny lunny deleted the lunny:lunny/fix_rewrite_public_keys branch Aug 6, 2019

lunny added a commit to lunny/gitea that referenced this pull request Aug 6, 2019
lunny added a commit that referenced this pull request Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.