Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dropTableColumns sqlite implementation (#7710) #7765

Merged

Conversation

@zeripath
Copy link
Contributor

commented Aug 5, 2019

  • Fix dropTableColumns sqlite implementation
  • use droptables and its index dropping support in v78 and v85
  • golang-ci fixes
  • Add migration from gitea 1.3.3 for sqlite which reveals the droptables bug - thus showing this works
Fix dropTableColumns sqlite implementation (#7710)
* Fix dropTableColumns sqlite implementation

* use droptables and its index dropping support in v78 and v85

* golang-ci fixes

* Add migration from gitea 1.3.3 for sqlite which reveals the droptables bug - thus showing this works

@zeripath zeripath added this to the 1.9.1 milestone Aug 5, 2019

@zeripath zeripath added the kind/bug label Aug 5, 2019

@lafriks
lafriks approved these changes Aug 5, 2019

@GiteaBot GiteaBot added the lgtm/need 1 label Aug 5, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Aug 6, 2019

@lafriks

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

Hi LG-TM, are you here? :)

@lafriks lafriks merged commit 1b5908f into go-gitea:release/v1.9 Aug 6, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details

@zeripath zeripath deleted the zeripath:backport-fix-droptablecolumns branch Aug 6, 2019

@lunny

This comment has been minimized.

Copy link
Member

commented Aug 19, 2019

back port from #7710

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
You can’t perform that action at this time.