Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Slack webhook fork message #7774

Merged
merged 1 commit into from Aug 6, 2019

Conversation

@WGH-
Copy link
Contributor

commented Aug 6, 2019

The order of forkee and fork was mixed up. I checked the code for other webhooks, and only Slack webhook was affected, other webhooks were doing it right.

I also changed to use full repository names (like other webhooks do).

Before fix (WGH/test is the original, WGH2/test is the fork):

test is forked to WGH/test

After fix:

WGH/test is forked to WGH2/test

Fix Slack webhook fork message
The order of forkee and fork was mixed up.
@codecov-io

This comment has been minimized.

Copy link

commented Aug 6, 2019

Codecov Report

Merging #7774 into master will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7774      +/-   ##
==========================================
+ Coverage    41.3%   41.32%   +0.01%     
==========================================
  Files         474      474              
  Lines       63834    63834              
==========================================
+ Hits        26368    26377       +9     
+ Misses      34028    34019       -9     
  Partials     3438     3438
Impacted Files Coverage Δ
models/webhook_slack.go 0% <0%> (ø) ⬆️
modules/log/event.go 64.61% <0%> (-1.03%) ⬇️
models/gpg_key.go 56.66% <0%> (+0.83%) ⬆️
models/repo_list.go 73.09% <0%> (+1.01%) ⬆️
routers/repo/view.go 43.25% <0%> (+1.01%) ⬆️
models/unit.go 67.56% <0%> (+5.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0470b16...2f2fccf. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 label Aug 6, 2019

@lafriks lafriks added this to the 1.9.1 milestone Aug 6, 2019

@lafriks lafriks modified the milestones: 1.9.1, 1.10.0 Aug 6, 2019

@lafriks

lafriks approved these changes Aug 6, 2019

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Aug 6, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Aug 6, 2019

@techknowlogick

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

ping LG-TM bot

@techknowlogick techknowlogick merged commit 28c5ae2 into go-gitea:master Aug 6, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
@techknowlogick

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

@WGH- would you be able to backport this to the release/v1.9 branch?

@WGH-

This comment has been minimized.

Copy link
Contributor Author

commented Aug 7, 2019

@WGH- would you be able to backport this to the release/v1.9 branch?

Yes. Will do that tomorrow (UTC-ish).

WGH- added a commit to WGH-/gitea that referenced this pull request Aug 7, 2019

Fix Slack webhook fork message (go-gitea#7774)
The order of forkee and fork was mixed up.

@lunny lunny added the backport/done label Aug 7, 2019

techknowlogick added a commit that referenced this pull request Aug 7, 2019

Fix Slack webhook fork message (#7774) (#7783)
The order of forkee and fork was mixed up.
@lunny lunny referenced this pull request Aug 20, 2019
2 of 7 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
You can’t perform that action at this time.