Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: fix multiple bugs with statuses endpoints (Backport #7785) #7807

Merged
merged 1 commit into from Aug 9, 2019

Conversation

@sapk
Copy link
Member

commented Aug 9, 2019

Backport #7785

api: fix multiple bugs with statuses endpoints (#7785)
* fix commit statuses api url

* search refs before passing sha

* adjust tests

* directly search tags and branches names + remove un-needed check in NewCommitStatus

* fix comment

* de-duplicate code

* test: use relative setting.AppURL

* Update routers/api/v1/repo/status.go

Co-Authored-By: Lauris BH <lauris@nix.lv>

* remove return

* Update routers/api/v1/repo/status.go

Co-Authored-By: Lauris BH <lauris@nix.lv>
@lafriks

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

Tests seem to fail

@sapk sapk force-pushed the sapk-fork:backport-7785 branch from 2054ec8 to c2f5cb5 Aug 9, 2019

@GiteaBot GiteaBot added the lgtm/need 2 label Aug 9, 2019

@lafriks lafriks added the kind/bug label Aug 9, 2019

@lafriks lafriks added this to the 1.9.1 milestone Aug 9, 2019

@sapk

This comment has been minimized.

Copy link
Member Author

commented Aug 9, 2019

Yes, I had to fix merge issue when cherry-picking and I let a test that wasn't before (and not related to the PR) and doesn't validate. I re-push a new merge in hope that it pass.

@lunny
lunny approved these changes Aug 9, 2019

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Aug 9, 2019

@lafriks
lafriks approved these changes Aug 9, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Aug 9, 2019

@lafriks lafriks merged commit 38e7997 into go-gitea:release/v1.9 Aug 9, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details

@sapk sapk deleted the sapk-fork:backport-7785 branch Aug 9, 2019

@MarkusAmshove MarkusAmshove referenced this pull request Aug 15, 2019
1 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.