Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate call of webhook #7821

Merged
merged 12 commits into from Aug 11, 2019

Conversation

@sapk
Copy link
Member

commented Aug 11, 2019

Try to fix #7702

sapk added 5 commits Aug 10, 2019
@codecov-io

This comment has been minimized.

Copy link

commented Aug 11, 2019

Codecov Report

Merging #7821 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7821      +/-   ##
==========================================
- Coverage   41.41%   41.39%   -0.02%     
==========================================
  Files         474      474              
  Lines       63877    63780      -97     
==========================================
- Hits        26453    26401      -52     
+ Misses      33980    33942      -38     
+ Partials     3444     3437       -7
Impacted Files Coverage Δ
models/webhook.go 57.08% <ø> (+0.57%) ⬆️
modules/pull/merge.go 37.17% <ø> (-2.52%) ⬇️
modules/repofiles/update.go 38.41% <ø> (-2.1%) ⬇️
modules/repofiles/delete.go 48.43% <ø> (-3.89%) ⬇️
modules/repofiles/upload.go 0% <ø> (ø) ⬆️
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️
modules/git/repo_commit.go 51.29% <0%> (-1.48%) ⬇️
models/repo_indexer.go 66.53% <0%> (+1.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bfeb85...d8d8668. Read the comment docs.

@lunny

This comment has been minimized.

Copy link
Member

commented Aug 11, 2019

@sapk It seems it still have two webhooks event when merged.

image

@lunny lunny added this to the 1.10.0 milestone Aug 11, 2019

modules/pull/merge.go Outdated Show resolved Hide resolved
@lunny
lunny approved these changes Aug 11, 2019

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Aug 11, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Aug 11, 2019

lafriks and others added 4 commits Aug 11, 2019
fmt

@lafriks lafriks merged commit e9bb75d into go-gitea:master Aug 11, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
@lafriks

This comment has been minimized.

Copy link
Member

commented Aug 11, 2019

Please backport

sapk added a commit to sapk-fork/gitea that referenced this pull request Aug 11, 2019

@sapk sapk deleted the sapk-fork:fix-webhook branch Aug 11, 2019

lunny added a commit that referenced this pull request Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
You can’t perform that action at this time.