Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpg/bugfix: Use .ExpiredUnix.IsZero to display green color of forever valid gpg key #7846

Merged
merged 2 commits into from Aug 14, 2019

Conversation

@sapk
Copy link
Member

commented Aug 13, 2019

We need to convert to time object to check if key is valid forever.
Similar to test later: https://github.com/go-gitea/gitea/pull/7846/files#diff-b39af036c147da90df23fbbd6b50e41fL29

Before:
image

After:
image

Related : #3153

@sapk sapk changed the title gpg/bug: Use .ExpiredUnix.IsZero to display green color of forever valid gpg key gpg/bugfix: Use .ExpiredUnix.IsZero to display green color of forever valid gpg key Aug 13, 2019

@techknowlogick techknowlogick added this to the 1.10.0 milestone Aug 13, 2019

@sapk

This comment has been minimized.

Copy link
Member Author

commented Aug 13, 2019

The last build failure seems unrelated I will force push to reload.

@sapk sapk force-pushed the sapk-fork:fix-tmpl-test-gpg-key branch from 43f84ab to 9f289af Aug 13, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Aug 14, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@0b2d399). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7846   +/-   ##
=========================================
  Coverage          ?   41.38%           
=========================================
  Files             ?      474           
  Lines             ?    63780           
  Branches          ?        0           
=========================================
  Hits              ?    26395           
  Misses            ?    33946           
  Partials          ?     3439

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b2d399...9f289af. Read the comment docs.

@lunny

lunny approved these changes Aug 14, 2019

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Aug 14, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Aug 14, 2019

@lunny lunny merged commit 7ffa3fc into go-gitea:master Aug 14, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
@lunny

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

Please send back port

@sapk sapk deleted the sapk-fork:fix-tmpl-test-gpg-key branch Aug 14, 2019

sapk added a commit to sapk-fork/gitea that referenced this pull request Aug 14, 2019

gpg/bugfix: Use .ExpiredUnix.IsZero to display green color of forever…
… valid gpg key (go-gitea#7846)

* Use .ExpiredUnix.IsZero for display green color of gpg key

* remove useless parentheses

lunny added a commit that referenced this pull request Aug 14, 2019

gpg/bugfix: Use .ExpiredUnix.IsZero to display green color of forever…
… valid gpg key (#7846) (#7850)

* Use .ExpiredUnix.IsZero for display green color of gpg key

* remove useless parentheses

@lunny lunny added the backport/done label Aug 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.