Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local runs of ssh-requiring integration tests #7855

Merged
merged 3 commits into from Aug 14, 2019

Conversation

@zeripath
Copy link
Contributor

commented Aug 14, 2019

The current ssh requiring tests will not run on my local machine due to the missing IdentitiesOnly option. This PR adds this required option to make it possible.

I have set this as backport because it's very small and self-contained and without it fixing bugs on the 1.9 branch is more difficult but not impossible so it might not need to be backported.

@sapk
sapk approved these changes Aug 14, 2019
@lunny
lunny approved these changes Aug 14, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Aug 14, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Aug 14, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@cbe3078). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7855   +/-   ##
=========================================
  Coverage          ?   41.39%           
=========================================
  Files             ?      474           
  Lines             ?    63817           
  Branches          ?        0           
=========================================
  Hits              ?    26416           
  Misses            ?    33960           
  Partials          ?     3441

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbe3078...e2e5abd. Read the comment docs.

@zeripath zeripath merged commit 176ba79 into go-gitea:master Aug 14, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details

@zeripath zeripath deleted the zeripath:fix-local-run-ssh-requiring-tests branch Aug 14, 2019

@lunny lunny added the backport/done label Aug 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
You can’t perform that action at this time.