Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix non existent milestone with 500 error instead of 404 #7867

Merged
merged 1 commit into from Aug 14, 2019

Conversation

@adelowo
Copy link
Member

commented Aug 14, 2019

Fixes #7864

@adelowo adelowo force-pushed the adelowo:fix_non_existent_milestone branch from 843cbd2 to 61283b1 Aug 14, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Aug 14, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@14230ca). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7867   +/-   ##
=========================================
  Coverage          ?   41.38%           
=========================================
  Files             ?      475           
  Lines             ?    63826           
  Branches          ?        0           
=========================================
  Hits              ?    26413           
  Misses            ?    33971           
  Partials          ?     3442
Impacted Files Coverage Δ
routers/repo/milestone.go 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14230ca...61283b1. Read the comment docs.

@sapk
sapk approved these changes Aug 14, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Aug 14, 2019

@techknowlogick techknowlogick merged commit a315c8d into go-gitea:master Aug 14, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
@techknowlogick

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

@adelowo please send backport :)

@adelowo adelowo deleted the adelowo:fix_non_existent_milestone branch Aug 14, 2019

adelowo added a commit to adelowo/gitea that referenced this pull request Aug 15, 2019
lunny added a commit that referenced this pull request Aug 15, 2019

@lunny lunny added the backport/done label Aug 15, 2019

aswild added a commit to aswild/gitea that referenced this pull request Aug 25, 2019
Merge tag 'v1.9.2' into wild/v1.9
* BUGFIXES
  * Fix wrong sender when send slack webhook (go-gitea#7918) (go-gitea#7924)
  * Upload support text/plain; charset=utf8 (go-gitea#7899)
  * Lfs/lock: round locked_at timestamp to second (go-gitea#7872) (go-gitea#7875)
  * Fix non existent milestone with 500 error (go-gitea#7867) (go-gitea#7873)
* SECURITY
  * Fix No PGP signature on 1.9.1 tag (go-gitea#7874)
  * Release built with go 1.12.9 to fix security fixes in golang std lib, ref: https://groups.google.com/forum/#!msg/golang-announce/oeMaeUnkvVE/a49yvTLqAAAJ
* ENHANCEMENT
  * Fix pull creation with empty changes (go-gitea#7920) (go-gitea#7926)
* BUILD
  * Drone/docker: prepare multi-arch release + provide arm64 image (go-gitea#7571) (go-gitea#7884)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
You can’t perform that action at this time.