Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lfs/lock: round locked_at timestamp to second #7872

Merged
merged 5 commits into from Aug 15, 2019

Conversation

@sapk
Copy link
Member

commented Aug 14, 2019

Fix #7871

@techknowlogick techknowlogick added this to the 1.10.0 milestone Aug 14, 2019

sapk added 2 commits Aug 15, 2019
@sapk

This comment has been minimized.

Copy link
Member Author

commented Aug 15, 2019

Fix and tests done. ready for review.

@codecov-io

This comment has been minimized.

Copy link

commented Aug 15, 2019

Codecov Report

Merging #7872 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7872      +/-   ##
==========================================
+ Coverage   41.37%   41.39%   +0.01%     
==========================================
  Files         475      475              
  Lines       63826    63826              
==========================================
+ Hits        26411    26419       +8     
+ Misses      33973    33964       -9     
- Partials     3442     3443       +1
Impacted Files Coverage Δ
models/lfs_lock.go 56.81% <100%> (ø) ⬆️
models/repo_list.go 73.09% <0%> (+1.01%) ⬆️
routers/repo/view.go 43.25% <0%> (+1.01%) ⬆️
models/unit.go 67.56% <0%> (+5.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a077c9d...484bd4f. Read the comment docs.

@lunny
lunny approved these changes Aug 15, 2019

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Aug 15, 2019

@lunny lunny added the backport/done label Aug 15, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Aug 15, 2019

lunny added a commit that referenced this pull request Aug 15, 2019
lfs/lock: round locked_at timestamp to second (#7872) (#7875)
* lfs/lock: round locked_at timestamp to second

* test returned locked_at values

* tests: use time RFC3339

@lunny lunny merged commit c2c35d1 into go-gitea:master Aug 15, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details

@sapk sapk deleted the sapk-fork:7871 branch Aug 15, 2019

aswild added a commit to aswild/gitea that referenced this pull request Aug 25, 2019
Merge tag 'v1.9.2' into wild/v1.9
* BUGFIXES
  * Fix wrong sender when send slack webhook (go-gitea#7918) (go-gitea#7924)
  * Upload support text/plain; charset=utf8 (go-gitea#7899)
  * Lfs/lock: round locked_at timestamp to second (go-gitea#7872) (go-gitea#7875)
  * Fix non existent milestone with 500 error (go-gitea#7867) (go-gitea#7873)
* SECURITY
  * Fix No PGP signature on 1.9.1 tag (go-gitea#7874)
  * Release built with go 1.12.9 to fix security fixes in golang std lib, ref: https://groups.google.com/forum/#!msg/golang-announce/oeMaeUnkvVE/a49yvTLqAAAJ
* ENHANCEMENT
  * Fix pull creation with empty changes (go-gitea#7920) (go-gitea#7926)
* BUILD
  * Drone/docker: prepare multi-arch release + provide arm64 image (go-gitea#7571) (go-gitea#7884)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
You can’t perform that action at this time.