Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CORS handler first for /api routes #7967

Merged
merged 3 commits into from Aug 26, 2019

Conversation

@tamalsaha
Copy link
Contributor

commented Aug 25, 2019

Signed-off-by: Tamal Saha tamal@appscode.com

Fixes #7840 #3 issue

Run CORS handler first for /api routes
Signed-off-by: Tamal Saha <tamal@appscode.com>
@tamalsaha tamalsaha referenced this pull request Aug 25, 2019
@codecov-io

This comment has been minimized.

Copy link

commented Aug 25, 2019

Codecov Report

Merging #7967 into master will increase coverage by 0.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7967      +/-   ##
==========================================
+ Coverage    41.5%   41.51%   +0.01%     
==========================================
  Files         479      479              
  Lines       63984    63983       -1     
==========================================
+ Hits        26554    26564      +10     
+ Misses      33974    33963      -11     
  Partials     3456     3456
Impacted Files Coverage Δ
routers/api/v1/api.go 71.56% <ø> (+0.2%) ⬆️
routers/routes/routes.go 82.14% <50%> (-0.27%) ⬇️
models/repo_list.go 74.14% <0%> (+0.97%) ⬆️
routers/repo/view.go 43.54% <0%> (+1.01%) ⬆️
models/unit.go 67.56% <0%> (+5.4%) ⬆️
modules/avatar/avatar.go 54% <0%> (+6%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5409dec...a3be026. Read the comment docs.

@lunny lunny added the kind/bug label Aug 25, 2019

@lunny lunny added this to the 1.10.0 milestone Aug 25, 2019

@lunny lunny added the backport/v1.9 label Aug 25, 2019

@lunny
lunny approved these changes Aug 25, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 2 labels Aug 26, 2019

@sapk sapk merged commit 6b3f52f into go-gitea:master Aug 26, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
@lafriks

This comment has been minimized.

Copy link
Member

commented Aug 26, 2019

please send backport to release/1.9 branch

tamalsaha added a commit to tamalsaha/gitea that referenced this pull request Sep 2, 2019
Run CORS handler first for /api routes (go-gitea#7967)
Signed-off-by: Tamal Saha <tamal@appscode.com>
lafriks added a commit that referenced this pull request Sep 2, 2019
Run CORS handler first for /api routes (#7967) (#8053)
Signed-off-by: Tamal Saha <tamal@appscode.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
You can’t perform that action at this time.