Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep blame view buttons sequence consistent with normal view when view a file #8007

Merged
merged 1 commit into from Aug 28, 2019

Conversation

@lunny
Copy link
Member

commented Aug 28, 2019

Before:

Normal View:
image

Blame View:
image

After:

Normal View:
image

Blame View:
image

@lunny lunny added this to the 1.10.0 milestone Aug 28, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Aug 28, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@9a5c6f3). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #8007   +/-   ##
========================================
  Coverage          ?   41.6%           
========================================
  Files             ?     479           
  Lines             ?   64106           
  Branches          ?       0           
========================================
  Hits              ?   26672           
  Misses            ?   33978           
  Partials          ?    3456

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a5c6f3...110c112. Read the comment docs.

@techknowlogick

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

LG-TM bot, please toggle.

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Aug 28, 2019

@techknowlogick techknowlogick merged commit 5616356 into go-gitea:master Aug 28, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
@techknowlogick

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

@lunny please send backport :)

@lunny lunny deleted the lunny:lunny/keep_consistent branch Aug 28, 2019

lunny added a commit to lunny/gitea that referenced this pull request Aug 28, 2019
sapk added a commit that referenced this pull request Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.