Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lfs locks #8361

Merged
merged 23 commits into from Oct 3, 2019

Conversation

@guillep2k
Copy link
Member

commented Oct 2, 2019

I've noticed that TestAPILFSLocksLogged() is recently failing due to a small time difference in the expected values.

Some time ago (#3167) the allowed margin was extended from 1 to 3 seconds. With this PR I'm extending it to 10, as the servers seem to be somewhat slower lately.

EDIT: this is the error produced in the automated tests:

image

guillep2k and others added 22 commits Sep 14, 2019
Update to github.com/lafriks/xormstore@v1.3.0 (#8317)
* [arc-green] white on hover for active menu items

Actually, hovered active menu elements are in an unreadable black text colour.
This should be changed to white.

* [arc-green] white on hover for active menu items
Actually, hovered active menu elements are in an unreadable black text colour.
This should be changed to white.

Now editing less files and commiting with `make css`.
…tc.) (#7756)

* Add API for Repo Advanced Settings of wiki and issue tracker

Signed-off-by: David Svantesson <davidsvantesson@gmail.com>

* Add some integration tests for tracker and wiki settings through API

* Should return StatusUnprocessableEntity in case of invalid API values.

* Add tests for invalid URLs for external tracker and wiki.

* Do not set inital values if they are default of type

* Make issue tracker and wiki units separate structures in Repository API structure.

Signed-off-by: David Svantesson <davidsvantesson@gmail.com>

* Fix comment of structures

Signed-off-by: David Svantesson <davidsvantesson@gmail.com>

* Rewrite API to use struct for setting tracker and wiki settings.

* LetOnlyContributorsTrackTime -> AllowOnlyContributorsToTrackTime
Update master
@sapk
sapk approved these changes Oct 2, 2019
@GiteaBot GiteaBot added the lgtm/need 1 label Oct 2, 2019
@sapk sapk added the kind/testing label Oct 2, 2019
@sapk

This comment has been minimized.

Copy link
Member

commented Oct 2, 2019

I re-started the CI that failed on a unrelated test.

@codecov-io

This comment has been minimized.

Copy link

commented Oct 2, 2019

Codecov Report

Merging #8361 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8361      +/-   ##
==========================================
+ Coverage   41.76%   41.77%   +<.01%     
==========================================
  Files         496      496              
  Lines       65610    65610              
==========================================
+ Hits        27403    27407       +4     
+ Misses      34691    34686       -5     
- Partials     3516     3517       +1
Impacted Files Coverage Δ
models/repo_list.go 74.14% <0%> (+0.97%) ⬆️
models/unit.go 67.56% <0%> (+5.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 740a0c4...5c9451e. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Oct 3, 2019
@techknowlogick techknowlogick added this to the 1.10.0 milestone Oct 3, 2019
@sapk sapk merged commit 0bda876 into go-gitea:master Oct 3, 2019
2 checks passed
2 checks passed
approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
@guillep2k guillep2k deleted the guillep2k:fix-lfs-locks branch Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
You can’t perform that action at this time.