Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix editor commit to new branch if PR disabled #8375

Merged
merged 2 commits into from Oct 5, 2019

Conversation

@guillep2k
Copy link
Member

commented Oct 4, 2019

Fixes #8371

@codecov-io

This comment has been minimized.

Copy link

commented Oct 4, 2019

Codecov Report

Merging #8375 into master will increase coverage by <.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #8375      +/-   ##
=========================================
+ Coverage    41.8%   41.8%   +<.01%     
=========================================
  Files         496     496              
  Lines       65586   65586              
=========================================
+ Hits        27416   27421       +5     
+ Misses      34654   34650       -4     
+ Partials     3516    3515       -1
Impacted Files Coverage Δ
routers/repo/editor.go 26.86% <33.33%> (ø) ⬆️
modules/log/event.go 65.64% <0%> (+1.02%) ⬆️
modules/process/manager.go 81.15% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f92a0b6...262444e. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 label Oct 4, 2019
@lafriks lafriks added the kind/bug label Oct 4, 2019
@lafriks lafriks added this to the 1.10.0 milestone Oct 4, 2019
@lafriks
lafriks approved these changes Oct 4, 2019
@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Oct 4, 2019
@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Oct 4, 2019
@lunny lunny merged commit fb7c23f into go-gitea:master Oct 5, 2019
2 checks passed
2 checks passed
approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
@lunny lunny added the backport/v1.9 label Oct 5, 2019
@lunny

This comment has been minimized.

Copy link
Member

commented Oct 5, 2019

Please send back port to v1.9

6543 added a commit to 6543-forks/gitea that referenced this pull request Oct 6, 2019
@6543

This comment has been minimized.

Copy link
Member

commented Oct 6, 2019

backport PR done @guillep2k @lunny

@lunny lunny added the backport/done label Oct 7, 2019
lunny added a commit that referenced this pull request Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
You can’t perform that action at this time.