Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc updated list of supported webhooks and added example #8388

Merged
merged 6 commits into from Oct 9, 2019

Conversation

@8ctopus
Copy link
Contributor

commented Oct 6, 2019

The list of supported webhooks was not up-to-date and I added an example of how to receive the hook.

}
// check authorization
if ($decoded['secret'] != $secret_key) {

This comment has been minimized.

Copy link
@techknowlogick

techknowlogick Oct 6, 2019

Member

You shouldn't rely on this field existing, it is currently deprecated as we are migrating towards using the checksum header to validate hook content. Would you be able to update this?

This comment has been minimized.

Copy link
@8ctopus

8ctopus Oct 6, 2019

Author Contributor

I didn't know and I actually just learnt about it from you. How does the new system work? Is there any doc about it yet?

This comment has been minimized.

Copy link
@techknowlogick

techknowlogick Oct 6, 2019

Member

Yes, this https://togithub.com/gogs/gogs/issues/4233 and this #3901 should provide details you are looking for :)

This comment has been minimized.

Copy link
@8ctopus

8ctopus Oct 6, 2019

Author Contributor

interesting indeed, let me check that and make changes to the script

This comment has been minimized.

Copy link
@8ctopus

8ctopus Oct 6, 2019

Author Contributor

@techknowlogick I've updated the code snippet and tested it. It works. I hope that's what you had in mind.

@GiteaBot GiteaBot added the lgtm/need 2 label Oct 6, 2019
@codecov-io

This comment has been minimized.

Copy link

commented Oct 6, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@5109d18). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #8388   +/-   ##
=========================================
  Coverage          ?   41.79%           
=========================================
  Files             ?      497           
  Lines             ?    65639           
  Branches          ?        0           
=========================================
  Hits              ?    27436           
  Misses            ?    34685           
  Partials          ?     3518

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5109d18...42dcfda. Read the comment docs.

@lunny lunny added the kind/docs label Oct 6, 2019
lunny and others added 2 commits Oct 6, 2019
Copy link
Member

left a comment

Thanks for all the docs improvements you are doing :)

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Oct 6, 2019
@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Oct 9, 2019
lafriks and others added 3 commits Oct 9, 2019
@zeripath zeripath merged commit e270896 into go-gitea:master Oct 9, 2019
2 checks passed
2 checks passed
approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
@zeripath zeripath added this to the 1.10.0 milestone Oct 9, 2019
@8ctopus 8ctopus deleted the 8ctopus:webhook branch Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
You can’t perform that action at this time.