Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version-validation for GO 1.13 (go-macaron/cors) #8389

Conversation

@6543
Copy link
Member

commented Oct 6, 2019

@6543 6543 force-pushed the 6543-forks:fix-go-dependency_macaron-cors branch from 7e30999 to d18ba45 Oct 6, 2019
6543 added 2 commits Oct 6, 2019
@techknowlogick techknowlogick added this to the 1.9.4 milestone Oct 6, 2019
@techknowlogick

This comment has been minimized.

Copy link
Member

commented Oct 6, 2019

Note for maintainers reviewing: This has been solved for gitea 1.10, however as we changed the upstream dependency we couldn't backport. This will allow 1.9.4 to be built with golang 1.13

@GiteaBot GiteaBot added the lgtm/need 2 label Oct 6, 2019
@techknowlogick

This comment has been minimized.

Copy link
Member

commented Oct 6, 2019

@6543 please update vendor/modules.txt as well

@6543 6543 changed the title fix version-validation (because of 1.12 -> 1.13 switch) WIP: fix version-validation (because of 1.12 -> 1.13 switch) Oct 6, 2019
@techknowlogick

This comment has been minimized.

Copy link
Member

commented Oct 6, 2019

nvm. I was looking at an old CI build

@6543 6543 changed the title WIP: fix version-validation (because of 1.12 -> 1.13 switch) fix version-validation (because of 1.12 -> 1.13 switch) Oct 6, 2019
@6543

This comment has been minimized.

Copy link
Member Author

commented Oct 6, 2019

build was succesfull!!
just runn the rest of the CI ...

@6543

This comment has been minimized.

Copy link
Member Author

commented Oct 6, 2019

@techknowlogick works 🗡

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Oct 6, 2019
@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Oct 6, 2019
@6543

This comment has been minimized.

Copy link
Member Author

commented Oct 6, 2019

CI done

@techknowlogick techknowlogick merged commit b6fba5b into go-gitea:release/v1.9 Oct 6, 2019
2 checks passed
2 checks passed
approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
@6543 6543 deleted the 6543-forks:fix-go-dependency_macaron-cors branch Oct 6, 2019
@6543

This comment has been minimized.

Copy link
Member Author

commented Oct 6, 2019

now we can build 1.9.x with new fixes ...

@6543 6543 changed the title fix version-validation (because of 1.12 -> 1.13 switch) Fix version-validation for GO 1.13 (go-macaron/cors) Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.